Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icloud.markdown: remove app specific password #20515

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

nlhomme
Copy link
Contributor

@nlhomme nlhomme commented Nov 30, 2021

As said by @dsfaller in the below issue, Apple changed the login flow or rejects app-specific passwords completely now:
home-assistant/core#53926 (comment)

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

As said by @dsfaller in the below issue, Apple changed the login flow or rejects app-specific passwords completely now:
home-assistant/core#53926 (comment)
@nlhomme nlhomme requested a review from Quentame as a code owner November 30, 2021 10:13
@homeassistant
Copy link

Hi @nlhomme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Nov 30, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nlhomme 👍

@frenck frenck merged commit 131d312 into home-assistant:current Nov 30, 2021
@nlhomme
Copy link
Contributor Author

nlhomme commented Dec 1, 2021

You're welcome ;)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
@nlhomme nlhomme deleted the patch-1 branch December 3, 2021 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants