Add humidity tracking to Venstar component #134936
Draft
+707
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-needed
core
integration: climate
integration: venstar
new-feature
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @garbled1, @jhollowe, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
What model of thermostat supports this? Where is the humidifying state set? |
|
I am using it with one of my T7900s in my dev environment.
…On Mon, Jan 6, 2025 at 5:45 PM John Hollowell ***@***.***> wrote:
What model of thermostat supports this? Where is the humidifying state set?
—
Reply to this email directly, view it on GitHub
<#134936 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOO7SSUTHMX54QVRPMAOXL2JMIR7AVCNFSM6AAAAABUWQH2G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUGEZDIMBVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
MartinHjelmare
requested changes
Jan 7, 2025
| @@ -25,6 +25,9 @@ class HVACMode(StrEnum): | |||
| # Device is in Dry/Humidity mode | |||
| DRY = "dry" | |||
|
|
|||
| # Device is in Humidify mode | |||
| HUMIDIFY = "humidify" | |||
There was a problem hiding this comment.
Please don't change the climate entity model.
Humidifying is represented by the humidifier entity in Home Assistant, not a climate entity.
https://developers.home-assistant.io/docs/core/entity/humidifier
|
Ok. I figured that since dehumidifying is an acceptable action for a
climate entity, humidifying could be equally acceptable. Would you
recommend that the climate integration I was hoping to extend should
implement a humidifier entity as well as a climate entity? Thanks in
advance; this is my first PR for HA :)
…On Tue, Jan 7, 2025 at 4:46 AM Martin Hjelmare ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In homeassistant/components/climate/const.py
<#134936 (comment)>
:
> @@ -25,6 +25,9 @@ class HVACMode(StrEnum):
# Device is in Dry/Humidity mode
DRY = "dry"
+ # Device is in Humidify mode
+ HUMIDIFY = "humidify"
Please don't change the climate entity model.
Humidifying is represented by the humidifier entity in Home Assistant, not
a climate entity.
https://developers.home-assistant.io/docs/core/entity/humidifier
—
Reply to this email directly, view it on GitHub
<#134936 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOO7SV7ZNHXUXXCVYZ3HMT2JOWALAVCNFSM6AAAAABUWQH2G2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZTHE4TSNZSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…me-assistant#133546) Co-authored-by: J. Nick Koston <[email protected]>
…ror messages (home-assistant#134950) refactor: Remove double "Error fetching" from error messages
* chore: Bump Renault api version * Update requirements_all.txt * Update requirements_test_all.txt
Increese download timeout
Update docs items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adding ability to capture current state of thermostat's humidifier output pin
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: