Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix build #7651

Merged
merged 4 commits into from
Jan 22, 2025
Merged

docs: Fix build #7651

merged 4 commits into from
Jan 22, 2025

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 22, 2025

Fix in holoviz-dev/nbsite#321

Changing this PR to fix some other build-related issues.

@hoxbro hoxbro changed the title build: Fix build docs: Fix build Jan 22, 2025
@hoxbro
Copy link
Member Author

hoxbro commented Jan 22, 2025

Also want to look into this warning:
image

edit: Done

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (b92f0c9) to head (e47f884).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7651      +/-   ##
==========================================
- Coverage   86.77%   86.75%   -0.03%     
==========================================
  Files         346      346              
  Lines       52217    52217              
==========================================
- Hits        45313    45302      -11     
- Misses       6904     6915      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Jan 22, 2025

Dark mode text should be updated:
image

edit: Done

.github/workflows/docs.yaml Outdated Show resolved Hide resolved
@hoxbro hoxbro marked this pull request as ready for review January 22, 2025 14:04
@hoxbro hoxbro requested a review from philippjfr January 22, 2025 14:04
@philippjfr philippjfr merged commit fe2f425 into main Jan 22, 2025
9 checks passed
@philippjfr philippjfr deleted the fix_build branch January 22, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants