Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate message params on send/stream methods #6830

Merged
merged 1 commit into from
May 14, 2024
Merged

Propagate message params on send/stream methods #6830

merged 1 commit into from
May 14, 2024

Conversation

ahuang11
Copy link
Contributor

Since one can do: ChatFeed(**message_params), it makes sense to also do it for send(**message_params) and stream(**message_params) too.

@ahuang11 ahuang11 added the type: enhancement Minor feature or improvement to an existing feature label May 14, 2024
@ahuang11 ahuang11 marked this pull request as ready for review May 14, 2024 00:10
@philippjfr philippjfr merged commit b904771 into main May 14, 2024
13 of 14 checks passed
@philippjfr philippjfr deleted the propagate_message_params_send branch May 14, 2024 11:29
philippjfr pushed a commit that referenced this pull request May 21, 2024
@ahuang11 @philippjfr
Propagate message params (#6830)
89be857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahuang11 @philippjfr