Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic chat reaction icons #6815

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented May 8, 2024

Follow up on https://github.com/holoviz/panel/pull/6807/files, properly implementing the fix

  • inserting the reactive expression directly (which indeed means it’ll be nested inside a ReactiveExpr pane which creates a layout)
  • handling updates to the reactive_icons correctly, so stylesheets, the link and show_reaction_icons are not reapplied.

@ahuang11 ahuang11 requested a review from philippjfr May 8, 2024 16:16
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 40.09%. Comparing base (b3fcdad) to head (dbbdd64).
Report is 10 commits behind head on main.

Files Patch % Lines
panel/tests/chat/test_message.py 18.18% 9 Missing ⚠️
panel/chat/message.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6815       +/-   ##
===========================================
- Coverage   81.54%   40.09%   -41.46%     
===========================================
  Files         314      314               
  Lines       46453    46575      +122     
===========================================
- Hits        37879    18672    -19207     
- Misses       8574    27903    +19329     
Flag Coverage Δ
ui-tests 40.09% <50.00%> (+2.61%) ⬆️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 41aa5f8 into main May 9, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the fix_dynamic_reaction_icons branch May 9, 2024 14:12
philippjfr pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants