Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise on ChatReactionIcons instance in ChatFeed.message_params #6814

Merged
merged 2 commits into from
May 8, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented May 8, 2024

import panel as pn

pn.extension()

chat_feed = pn.chat.ChatFeed(reaction_icons=pn.chat.ChatReactionIcons(options={"like": "thumb-up", "dislike": "thumb-down"}))
msg1 = chat_feed.send("Hello")
msg2 = chat_feed.send("Hey")

msg1.reactions = ["like"]

chat_feed

No longer linked

image

@ahuang11 ahuang11 requested a review from philippjfr May 8, 2024 14:48
panel/chat/feed.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 changed the title Prevent chat reaction icons from being linked across messages Raise on ChatReactionIcons instance in ChatFeed.message_params May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 40.25%. Comparing base (b3fcdad) to head (6330c59).
Report is 9 commits behind head on main.

Files Patch % Lines
panel/tests/chat/test_feed.py 50.00% 2 Missing ⚠️
panel/chat/feed.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6814       +/-   ##
===========================================
- Coverage   81.54%   40.25%   -41.29%     
===========================================
  Files         314      314               
  Lines       46453    46560      +107     
===========================================
- Hits        37879    18744    -19135     
- Misses       8574    27816    +19242     
Flag Coverage Δ
ui-tests 40.25% <72.72%> (+2.78%) ⬆️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit d5d4237 into main May 8, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the fix_chat_reaction_icons branch May 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants