Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jupyter Panel Preview in Windows #4826

Merged
merged 2 commits into from
May 12, 2023
Merged

Fix Jupyter Panel Preview in Windows #4826

merged 2 commits into from
May 12, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 12, 2023

Fixes #4819

The path string was not raw, which meant on Windows, the path would give a Unicode error. I also added more logging if the msg_type is an error.

image

@MarcSkovMadsen
Copy link
Collaborator

I'm so happy for

  • the fix
  • that it was not me speaking out very loudly about a problem that was on my side 😄

Thanks a lot @hoxbro . My hero 🦸

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #4826 (3d980c4) into main (456334e) will decrease coverage by 0.81%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4826      +/-   ##
==========================================
- Coverage   83.40%   82.59%   -0.81%     
==========================================
  Files         269      269              
  Lines       37986    37975      -11     
==========================================
- Hits        31681    31367     -314     
- Misses       6305     6608     +303     
Flag Coverage Δ
ui-tests 40.80% <0.00%> (+0.01%) ⬆️
unitexamples-tests 72.04% <0.00%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Thank you both, glad we were able to track this down!

@MarcSkovMadsen
Copy link
Collaborator

I tried the fix locally and can confirm it works for me

image

image

@philippjfr philippjfr merged commit 7347ac5 into main May 12, 2023
@philippjfr philippjfr deleted the fix_windows_path branch May 12, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter Panel Preview not working on main
3 participants