Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return value from DateTimeImmutable::createFromFormat() #46

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Fix return value from DateTimeImmutable::createFromFormat() #46

merged 4 commits into from
Oct 2, 2019
+30 −3

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Jul 11, 2019 •
edited
Loading

When the format string contains ! or !, the DateTime (mutable) class is returned.

refs #30

@zonuexe
Copy link
Contributor Author

zonuexe commented Jul 11, 2019 •
edited
Loading

$ phpenv global 5.4
rbenv: version `5.4’ not installed
The command "phpenv global 5.4” failed and exited with 1 during .

$ phpenv global 5.5
rbenv: version `5.5' not installed
The command "phpenv global 5.5" failed and exited with 1 during .

🙃

@IonBazan
Copy link
Contributor

@zonuexe I think you may need to add: dist: trusty for these old versions to work.

@zonuexe
Copy link
Contributor Author

zonuexe commented Jul 11, 2019

It looks like the test passed except for PHP 7.3. The measures must be taken at the other PR.

IonBazan
IonBazan reviewed Jul 11, 2019
View reviewed changes
.travis.yml Outdated
@@ -1,5 +1,6 @@
sudo: false
language: php
dist: trusty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using trusty only for legacy PHP versions:

matrix:
   include:
    - dist: trusty
      php: 5.4
    - dist: trusty
      php: 5.5
  allow_failuers:
    - php: master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the tests failed for master. Add 7.3 to the list of supported versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IonBazan Thank you for your suggestion!

@zonuexe
Copy link
Contributor Author

zonuexe commented Jul 11, 2019

The changes in .travis.yml are reverted as they seem to have blocked the launch of Travis CI.

@IonBazan
Copy link
Contributor

@zonuexe Probably due to invalid syntax. Please check it with http://lint.travis-ci.org/ first.

@hnw
Copy link
Owner

hnw commented Oct 2, 2019

Thanks, good catch.

@hnw hnw merged commit fd6667c into hnw:master Oct 2, 2019
@zonuexe zonuexe deleted the fix/issue-30 branch October 2, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonBazan IonBazan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zonuexe @IonBazan @hnw