Dev cncomponentstyling #29
Merged
+243
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add loading state spinner, icon positioning props, and full-width option to make our Button component more intuitive and require less markup. - Developers can now use leftIcon/rightIcon props instead of nesting elements, and enable loading states with a single prop. Example: - Before: <Button><Spinner /><span>Loading...</span></Button> - After: <Button loading>Loading...</Button>
Refactor Card component to use a compound pattern with a single export point. Now developers can import just the Card component and access all sub-components through it (Card.Header, Card.Title, etc). Added Card.create() helper function for quick card creation. Makes the component more intuitive and reduces import statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui): Enhance button component with improved developer experience
feat(ui): refactor Card component to a compound component pattern