Implementation of Preview Page #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functionality-final)
… functionality-finalv0.5)
… functionality-finalv0.5:fixed-lint-issues)
… functionality-finalv0.5)
… functionality-finalv0.5:fixed-lint-issues)
… functionality-finalv0.5:restore-settings.json)
…favouridoko1/hng_boilerplate_remix into feat/HNG-14-create-preview-page
|
@favouridoko1 60 commits? |
abiona01
requested changes
Jul 21, 2024
Comment on lines
+1
to
+20
| <!-- <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Document</title> | ||
| </head> | ||
| <body style="font-family: 'Poppins', Arial, sans-serif"> | ||
| <table width="100%" border="0" cellspacing="0" cellpadding="0" class="staticSiteContainer"> | ||
| <tr> | ||
| <td align="center" style="padding: 20px"> | ||
| <table | ||
| class="content" | ||
| width="600" | ||
| border="0" | ||
| cellspacing="0" | ||
| cellpadding="0" | ||
| style="border-collapse: collapse; border: 1px solid #cccccc" | ||
| > | ||
| <!-- Header --> |
| @@ -1,10 +1,17 @@ | |||
| import type { MetaFunction } from "@remix-run/node"; | |||
| import { useState } from "react"; | |||
| import { Button } from "~/Components/ui/button"; | |||
| // import fs from "fs/promises" | |||
| try { | ||
|
|
||
| const res = await fetch(`${htmlLink}`); | ||
| // https://res.cloudinary.com/dbx3hnvcf/raw/upload/v1721483612/index_ox46if.html |
abiona01
requested changes
Jul 22, 2024
Comment on lines
-5
to
-32
| @layer base { | ||
| :root { | ||
| --background: 0 0% 100%; | ||
| --foreground: 224 71.4% 4.1%; | ||
| --card: 0 0% 100%; | ||
| --card-foreground: 224 71.4% 4.1%; | ||
| --popover: 0 0% 100%; | ||
| --popover-foreground: 224 71.4% 4.1%; | ||
| --primary: 220.9 39.3% 11%; | ||
| --primary-foreground: 210 20% 98%; | ||
| --secondary: 220 14.3% 95.9%; | ||
| --secondary-foreground: 220.9 39.3% 11%; | ||
| --muted: 220 14.3% 95.9%; | ||
| --muted-foreground: 220 8.9% 46.1%; | ||
| --accent: 220 14.3% 95.9%; | ||
| --accent-foreground: 220.9 39.3% 11%; | ||
| --destructive: 0 84.2% 60.2%; | ||
| --destructive-foreground: 210 20% 98%; | ||
| --border: 220 13% 91%; | ||
| --input: 220 13% 91%; | ||
| --ring: 224 71.4% 4.1%; | ||
| --radius: 0.5rem; | ||
| --chart-1: 12 76% 61%; | ||
| --chart-2: 173 58% 39%; | ||
| --chart-3: 197 37% 24%; | ||
| --chart-4: 43 74% 66%; | ||
| --chart-5: 27 87% 67%; | ||
| } |
There was a problem hiding this comment.
Hold on, you delete styling in the global.css file? RETURN THEM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #issue_number_here
Changes proposed
What were you told to do?
What did you do?
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots/Videos