Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CookieConsent folder #245

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

Kwasako
Copy link
Collaborator

@Kwasako Kwasako commented Jul 20, 2024

Description

Closes #issue_number_here

Changes proposed

What were you told to do?

What did you do?

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Kwasako added 2 commits July 21, 2024 00:07
feat: add expand and collapse icon
@chumex412
Copy link
Contributor

Resolve conflicts and attach screenshots of desktop and mobile view

className="ml-4"
onClick={toggleExpand}
role="button"
tabIndex={0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ShadCN modal component please

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried installing ShadCN UI but got an error
Screenshot 2024-07-21 115510

},
{
title: "Functional Cookies",
id: "fc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this array: cookSettings outside this file, to app/data/ui.ts

@chumex412 chumex412 self-requested a review July 21, 2024 10:43
Copy link
Contributor

@chumex412 chumex412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement asked fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants