-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Allow Admins to Update Multiple Products in a Single Request. #1179
Open
Lamido-stack
wants to merge
7
commits into
hngprojects:dev
Choose a base branch
from
Lamido-stack:Batch-Product-Update
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
88e74ae
feat: Allow Admins to Update Multiple Products in a Single Request.
Lamido-stack 8f2693d
Merge branch 'dev' into Batch-Product-Update
Lamido-stack 3399355
Merge branch 'dev' into Batch-Product-Update
Lamido-stack 5f39b95
Merge branch 'dev' into Batch-Product-Update
Lamido-stack d72f91d
Merge branch 'dev' into Batch-Product-Update
Lamido-stack bfcd00f
Merge branch 'dev' into Batch-Product-Update
Lamido-stack 4616e14
Merge branch 'dev' into Batch-Product-Update
Lamido-stack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of fetching each product individually inside the loop, retrieve all products at once using a single query before entrying the loop for update.
This reduces the number of DB hits and speeds up processing.