feat: add yearly option to billing plan DTO and fix validation issue #1355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR resolves validation issues in BillingPlanDto to ensure:
✅ Frequency only accepts "monthly" or "yearly".
✅ Amount is properly validated as a number instead of a string
@IsIn(['monthly', 'yearly'])
to enforce valid values.@IsNumberString()
→@IsNumber()
to correctly handle numeric values.Related Issue
Fixes: #120
Fixes #(issue)
Type of Change
✨ Feature: New functionality
How Has This Been Tested?
Unit test with using jest to test validations
Test Evidence
Screenshots (if applicable)
Documentation Screenshots (if applicable)
{
"name": "Premium Yearly",
"description": "Yearly plan with full features",
"frequency": "yearly",
"amount": 1200,
"is_active": true
}
Checklist
Additional Notes
Further validation can be added if required, such as ensuring yearly pricing is 12x the monthly price.