Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:removed await from non async function #1350

Closed
wants to merge 9 commits into from

Conversation

urizennnn
Copy link
Contributor

@urizennnn urizennnn commented Mar 1, 2025

Description

This PR removes deprecated functions and improves code encapsulation. Specifically:

  • Replaces toPromise() by directly handling the firstValueFrom data response.
  • Ensures that await is only used in async functions.
  • Updates function visibility where necessary (publicprivate or protected).
  • Fixed constructuor/service function to reference values using the ts this keyword correctly.

Related Issue

Fixes #1220

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Test Evidence

✅ All tests passed. (See attached screenshot)

Screenshots (if applicable)

Documentation Screenshots (if applicable)

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

This refactor ensures the stability and maintainability of the codebase by removing deprecated features and enforcing better encapsulation.

@urizennnn urizennnn closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE]:Remove deprecated function in FLW service
1 participant