feat: add endpoint to delete timezones

[Poeticrow]

Pull Request

Description

This PR implements the timezone deletion feature in the TimezonesService and improves error handling.
Key changes:

• Added a deleteTimezone method to remove a timezone by ID.
• Ensured proper error handling:
  • Returns NotFoundException if the timezone does not exist.
  • Returns InternalServerErrorException only for unexpected errors.
• Improved logging with Logger.error for better debugging.
• Updated test cases:
  • Added unit tests for successful deletion.
  • Added test for NotFoundException when an invalid ID is provided.
  • Mocked repository methods correctly for expected behavior.
• Fixed a bug where the catch block was overriding NotFoundException with InternalServerErrorException.

Related Issue

Fixes #1336

Type of Change

• feat: New feature
• fix: Bug fix
• docs: Documentation updates
• style: Code style/formatting changes
• refactor: Code refactoring
• perf: Performance improvements
• test: Test additions/updates
• chore: Build process or tooling changes
• ci: CI configuration changes
• other:

How Has This Been Tested?

• Unit tests
• Integration tests
• Manual tests

Test Evidence

✅ All unit tests are passing
✅ Verified NotFoundException is thrown correctly
✅ Verified correct success response for valid deletions

Screenshots (if applicable)

Documentation Screenshots (if applicable)

N/A (No UI changes)

Checklist

• My code follows the project's coding style
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published
• I have included a screenshot showing all tests passing
• I have included documentation screenshots (if applicable)

Additional Notes

• This change ensures that API consumers receive a clear error message when trying to delete a non-existent timezone.
• No breaking changes expected, but API consumers should handle the NotFoundException properly.

[theblvckdev]

Update your branch

[Poeticrow]

Update your branch

It's done.

[theblvckdev]

This PR title isn't following best practices for several reasons:

1. Format inconsistency: While "Feat/" is attempting to follow conventional commits format, the standard would be "feat:" (with a colon, not a slash).

2. Lack of clarity: The title is vague about whether you're adding or deleting a timezone endpoint.

A better PR title would be:

feat: add endpoint to delete timezones

This improved title:

• Uses the proper conventional commit format with lowercase "feat:" and a colon
• Clearly states the action (adding an endpoint) and its purpose (to delete timezones)
• Removes uncertainty
• Follows the imperative mood ("add" rather than "adding")

Following consistent PR naming conventions helps with release notes generation, makes the git history more readable, and helps team members quickly understand the purpose of changes.

[Poeticrow]

This PR title isn't following best practices for several reasons:

1. Format inconsistency: While "Feat/" is attempting to follow conventional commits format, the standard would be "feat:" (with a colon, not a slash).
2. Lack of clarity: The title is vague about whether you're adding or deleting a timezone endpoint.

A better PR title would be:

feat: add endpoint to delete timezones

This improved title:

• Uses the proper conventional commit format with lowercase "feat:" and a colon
• Clearly states the action (adding an endpoint) and its purpose (to delete timezones)
• Removes uncertainty
• Follows the imperative mood ("add" rather than "adding")

Following consistent PR naming conventions helps with release notes generation, makes the git history more readable, and helps team members quickly understand the purpose of changes.

Thank you. I've corrected it