Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature exclude soft deleted organisations from queries #1338

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from

Conversation

dainty92
Copy link

@dainty92 dainty92 commented Mar 1, 2025

Pull Request

Description

This PR fixes an issue where soft-deleted organizations were still being included in queries. The update ensures that queries exclude organizations that have been marked as deleted, improving data integrity and preventing unintended results.

Related Issue

Fixes #1283 - #1283

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Test Evidence

Query results now correctly exclude soft-deleted organizations.

Screenshots (if applicable)

Documentation Screenshots (if applicable)

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

The Husky deprecation warning appeared during commit, but it did not prevent pushing the changes.

@dainty92
Copy link
Author

dainty92 commented Mar 3, 2025

Kindly help review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Soft Delete Issue: Deleted Organizations Still Appear in Queries
2 participants