Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Product Category and Variant Relations #1332

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

BigLens
Copy link

@BigLens BigLens commented Mar 1, 2025

Pull Request

Description

This PR introduces a fix to the Product-Category relationship and ensures proper handling of variants within the Product entity.

Related Issue

#1250

Fixes #1250

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

## Changes Implemented

  • Added Many-to-One and One-to-Many relationships between Product and ProductCategory.
  • Updated the Product entity to correctly reference ProductCategory instead of storing it as a string.
  • Refactored the seeding script to properly associate products with categories instead of assigning category names as strings.
  • Resolved repository injection errors in ProductsService.
  • Ensured that all affected code runs without breaking existing functionalities.

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

No database migrations were performed, as this is a boilerplate repository.
Migration files may need to be generated and reviewed if this is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] - Product Created Without Category and Variant
1 participant