Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unauthorized error in product update, product stock data retrieval and comment addition #1331

Merged

Conversation

PreciousIfeaka
Copy link
Contributor

Pull Request

Description

  1. The update product feature had authorization errors based on the fact that the endpoint didn't accept organization id as a query parameter and it is required in the organization ownership guard. I fixed this by adding orgId to the query params for the endpoint.
  2. Same issue happened for product stock retrieval. Fixed it using the same method as above.
  3. The addition of comment to a product feature failed because the addCommentDto doesn't contain some required fields in the Comment entity. I fixed this by making these fields optional in the entity.

Related Issue

Issue 1
Issue 2

Fixes #1286 #1287

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Test Evidence

Screenshot 2025-03-01 125652
Screenshot 2025-03-01 125715

Screenshots (if applicable)

Documentation Screenshots (if applicable)

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

@PreciousIfeaka PreciousIfeaka changed the title fix: fixed unauthorized error in product update, product stock data retrieval and comment addition fix: unauthorized error in product update, product stock data retrieval and comment addition Mar 1, 2025
@incredible-phoenix246 incredible-phoenix246 merged commit d706e90 into hngprojects:dev Mar 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX]: Add organization consideration to product comment
2 participants