Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement API Rate Limiting with ThrottlerModule #1329

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

NnatuanyaFrankOguguo
Copy link

Pull Request

Description

This PR implements global API rate limiting using @nestjs/throttler to enhance security and performance.

Fixes #(issue)

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

How Has This Been Tested?

  • Unit tests
  • [x ] Integration tests
  • Manual tests

Test Evidence

Screenshot (241)
Screenshot (242)

Screenshots (if applicable)

Documentation Screenshots (if applicable)

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

This implementation ensures that users who exceed the request limit receive a 429 Too Many Requests response. The limit is configurable and can be adjusted in the app.module.ts.

@omotomiwa26 omotomiwa26 requested a review from Homoakin619 March 1, 2025 10:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this. Don't push your docker-compose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this is not supposed to be pushed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright alright thanks... let me work on it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file. Why are you removing anything from this place

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cant removed the .gitignore file that is what is preventing the node modules and others file from being pushed. the previous conflicts that i resolved was that from the package-lock.json then i had to pull the changes made from the dev branch to my branch and push it back to resolved the changes and i remove the package-lock.json in the .gitignore file that is preventing it from being push..

Copy link
Author

@NnatuanyaFrankOguguo NnatuanyaFrankOguguo Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added what i remove from the .gitignore file back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants