-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement API Rate Limiting with ThrottlerModule #1329
base: dev
Are you sure you want to change the base?
feat: Implement API Rate Limiting with ThrottlerModule #1329
Conversation
docker-compose.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this. Don't push your docker-compose
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this is not supposed to be pushed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright alright thanks... let me work on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file. Why are you removing anything from this place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i cant removed the .gitignore file that is what is preventing the node modules and others file from being pushed. the previous conflicts that i resolved was that from the package-lock.json then i had to pull the changes made from the dev branch to my branch and push it back to resolved the changes and i remove the package-lock.json in the .gitignore file that is preventing it from being push..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have added what i remove from the .gitignore file back.
Pull Request
Description
This PR implements global API rate limiting using
@nestjs/throttler
to enhance security and performance.Fixes #(issue)
Type of Change
How Has This Been Tested?
Test Evidence
Screenshots (if applicable)
Documentation Screenshots (if applicable)
Checklist
Additional Notes
This implementation ensures that users who exceed the request limit receive a 429 Too Many Requests response. The limit is configurable and can be adjusted in the app.module.ts.