Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement S3 resume upload for job applications #1320

Merged

Conversation

LivingHopeDev
Copy link
Contributor

Pull Request

Description

This PR implements the functionality to upload resumes to AWS S3 instead of storing them as raw strings. The feature enhances the job application process by ensuring resumes are securely stored and retrieved via URLs.

Related Issue

Fixes #(issue)

Type of Change

  • feat: New feature

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Test Evidence

Screenshots (if applicable)

hng-test
postman-test

Documentation Screenshots (if applicable)

swagger-test

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

Environment Variables to be Added in Production

To deploy this feature, please ensure the following AWS S3 credentials are added to the production environment:

AWS_ACCESS_KEY=<your-access-key>
AWS_SECRET_ACCESS_KEY=<your-secret-key>
AWS_REGION=<your-aws-region>
AWS_S3_BUCKET_NAME=<your-bucket-name>

Copy link
Contributor

@incredible-phoenix246 incredible-phoenix246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not just resume all files including images go to s3 effect the change

@incredible-phoenix246
Copy link
Contributor

Nice work

@incredible-phoenix246 incredible-phoenix246 merged commit 06283ce into hngprojects:dev Mar 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants