Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: comment delete by admin #1314

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat: comment delete by admin #1314

wants to merge 2 commits into from

Conversation

zickycodes
Copy link

@zickycodes zickycodes commented Feb 28, 2025 •
edited
Loading

Pull Request

Description

Comment Deletion By Admin

Related Issue

#1299

Fixes #(issue)

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Test Evidence

image

Screenshots (if applicable)

image

Documentation Screenshots (if applicable)

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

Hng

@zickycodes
Copy link
Author

bhng_test

incredible-phoenix246
incredible-phoenix246 requested changes Mar 1, 2025
View reviewed changes
src/modules/comments/comments.controller.ts
@@ -14,6 +16,7 @@ export class CommentsController {
@ApiResponse({ status: 201, description: 'The comment has been successfully created.', type: CommentResponseDto })
@ApiResponse({ status: 400, description: 'Bad Request.' })
@ApiResponse({ status: 500, description: 'Internal Server Error.' })
@UseGuards(AuthGuard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User the admin guard instead of manual check

package-lock.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incredible-phoenix246 incredible-phoenix246 incredible-phoenix246 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zickycodes @incredible-phoenix246