Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Add base templates to all Handlebars email templates #1308

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Amaksss
Copy link

@Amaksss Amaksss commented Feb 28, 2025

Pull Request

Description

This PR updates the email templating system to properly integrate base.hbs

The changes include:

Using {{#> base}} in child templates to ensure they inherit the structure from base.hbs.
Fixing Handlebars syntax errors to prevent rendering issues.
Ensuring consistency across email templates by standardizing how content is injected into base.hbs.

Related Issue

#1226

Fixes #(issue)

Type of Change

refactor: Code refactoring

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • [x ] refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes
  • other:

How Has This Been Tested?

Test Evidence

Screenshots (if applicable)

Documentation Screenshots (if applicable)

Checklist

  • [x ] My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

@TheCodeGhinux
Copy link
Contributor

Can you fix the title??

@Amaksss Amaksss changed the title added base template to all handlebars email templates [ENHANCEMENT]: Add base templates to all Handlebars email templates Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants