Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Soft Delete Issue: Deleted Organizations Still Appear in Queries #1283

Open
dainty92 opened this issue Feb 28, 2025 · 1 comment · May be fixed by #1338
Open

[FIX] Soft Delete Issue: Deleted Organizations Still Appear in Queries #1283

dainty92 opened this issue Feb 28, 2025 · 1 comment · May be fixed by #1338
Assignees
@dainty92
Labels
bug Something isn't working

Comments

@dainty92
Copy link

Bug Description

The deleteOrganisation method sets isDeleted to true, but it does not filter out deleted organizations in other methods. This means that queries do not exclude soft-deleted organizations.

Steps to Reproduce

  1. Call the deleteOrganisation method on an organization.
  2. Try fetching organizations via the API.
  3. The deleted organization is still included in the results.

Expected Behavior

  • The deleted organizations should not appear in query results.

Current Behavior

  • Deleted organizations still show up in queries.

Screenshots/Logs

Environment

  • OS: [e.g. Windows, macOS, Linux]
  • Browser/Device: [e.g. Chrome, Firefox, iPhone]
  • Version: [e.g. 22]

Possible Solution

  • Modify queries to exclude records where isDeleted = true.

Additional Context
@dainty92 dainty92 added the bug Something isn't working label Feb 28, 2025
@dainty92 dainty92 changed the title [FIX] Soft Delete Not Applied: Deleted Organizations Still Appear in Queries Feb 28, 2025
@dainty92 dainty92 changed the title Soft Delete Not Applied: Deleted Organizations Still Appear in Queries [FIX] Soft Delete Issue: Deleted Organizations Still Appear in Queries Feb 28, 2025
@github-project-automation github-project-automation bot moved this to Backlogs in Boilerplate-TS Feb 28, 2025
@AdeGneus AdeGneus moved this from Backlogs to Mentors Approved in Boilerplate-TS Feb 28, 2025
@TheCodeGhinux
Copy link
Contributor

That is the whole idea of soft delete.

@dainty92 dainty92 linked a pull request Mar 1, 2025 that will close this issue
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dainty92 dainty92

Labels
bug Something isn't working
Projects
Boilerplate-TS
Status: Mentors Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature exclude soft deleted organisations from queries dainty92/hng_boilerplate_nestjs
2 participants
@TheCodeGhinux @dainty92