ci: improve healthchecks, expose nginx - be careful with docker volumes

hngprojects · Aug 12, 2024 · 1079926 · 1079926
1 parent f0b6545
commit 1079926
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/compose.yaml b/compose.yaml
@@ -12,7 +12,7 @@ services:
       redis:
         condition: service_healthy
     healthcheck:
-      test: "wget -qO- http://localhost:3000"
+      test: "wget -qO- http://app:5000"
       interval: 5s
       timeout: 5s
       retries: 3
@@ -49,13 +49,15 @@ services:
 
   nginx:
     image: nginx:alpine
+    ports:
+      - 5000:80
     volumes:
       - ./nginx.conf:/etc/nginx/nginx.conf
     depends_on:
       app:
         condition: service_healthy
     healthcheck:
-      test: "wget -qO- http://localhost:80"
+      test: "wget -qO- http://nginx:80"
       interval: 5s
       timeout: 5s
       retries: 3

diff --git a/dockerfile b/dockerfile
@@ -12,7 +12,7 @@ RUN npm install
 
 RUN npm run build
 
-EXPOSE 3100
+EXPOSE 5000
 
 # Command to run the application
 CMD ["npm", "run", "start:prod"]