Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: interfaced the key services #383

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

samuelIkoli
Copy link

@samuelIkoli samuelIkoli commented Mar 1, 2025

Description

To improve code modularity, testability, and adherence to the dependency inversion principle, key services where refactored to utilize interfaces.

Related Issue (Link to Github issue)

#367

How Has This Been Tested?

I ran automated and reliable test files that have been pre-written after creating a docker container to simulate the environment. I also manually tested on postman.

Screenshots of terminal automation and postman key creation tests:

Screenshot 2025-03-01 at 1 09 33 AM Screenshot 2025-03-01 at 1 19 46 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants