Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: filter by category #437

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

Odili1
Copy link

@Odili1 Odili1 commented Mar 1, 2025

Description

Closes #412

Changes proposed

What were you told to do?

Add Category as an optional query parameter to filter products by an organization based on category
Add checks to verify that the category provided in the query is a valid category
Update the unit test for this handler to account for the changes made

What did you do?

Added Category as an optional query parameter to filter products by an organization based on category
Added checks to verify that the category provided in the query is a valid category
Updated the unit test for this handler to account for the changes made

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

  • Successful Response without category query
    noCategory

  • Successful Response with category query
    categoryFilter

  • Error Response with Invalid category query
    invalidCategoryQuery

Copy link
Contributor

@Heba-WebDev Heba-WebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Heba-WebDev
Copy link
Contributor

The title should be "Fix: filter by category"

@Odili1 Odili1 changed the title Fix/filter by category Fix: filter by category Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] Filter products by category in Get all Product endpoint
2 participants