fix: pass faucet address env var to stacks network #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #97 +/- ##
===========================================
+ Coverage 79.63% 79.71% +0.08%
===========================================
Files 13 13
Lines 1414 1410 -4
===========================================
- Hits 1126 1124 -2
+ Misses 288 286 -2 ☔ View full report in Codecov by Sentry. |
MicaiahReid
reviewed
Jun 14, 2024
MicaiahReid
approved these changes
Jun 17, 2024
blockstack-devops
pushed a commit
that referenced
this pull request
Jun 17, 2024
## [1.2.1](v1.2.0...v1.2.1) (2024-06-17) ### Bug Fixes * pass faucet address env var to stacks network ([#97](#97)) ([a543e86](a543e86))
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The faucet address should be passed in env vars when starting a stacks network, like here: https://github.com/hirosystems/clarinet/blob/b58cca5dce734bd9433d389e466fd5ea6018460f/components/stacks-network/src/orchestrator.rs#L1893
Closes https://github.com/hirosystems/platform/issues/1184