Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade clarinet to v2.4.0; enable use_nakamoto field to configure stacks chain for nakamoto #89

Merged
merged 20 commits into from
Mar 25, 2024

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Feb 8, 2024

Description

This PR upgrades the internal Clarinet dependency to v2.4.0. The Devnet API uses Clarinet's types for validation of user input (Devnet.toml, Clarinet.toml, etc), so the request body for the creation of a Devnet (POST localhost:8477/api/v1/networks) must come from the clarinet devnet package command of Clarinet v2.4.0+.

This PR also uses the new use_nakamoto field in the Devnet.toml to make the following changes (if the field is true):

  • configure the stacks node's settings for nakamoto:
    • setting the epoch 2.5 and epoch 3.0 fields
    • configuring the Stacks signers as event observers
  • update the image used for the stacks node to match the DEFAULT_STACKS_NODE_IMAGE_NAKA export from Clarinet
  • update the image used for the stacks api to match the DEFAULT_STACKS_API_IMAGE_NAKA export from Clarinet
  • deploy 2 new stateful sets, the Stacks signers

Fixes #88

Breaking change?

Technically this is breaking because the above reasoning of needing to stay in step with the Clarinet version.

Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 79.63801% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 79.37%. Comparing base (47417d5) to head (e77dab6).

Files Patch % Lines
src/lib.rs 78.17% 43 Missing ⚠️
src/resources/pod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
- Coverage    80.53%   79.37%   -1.17%     
===========================================
  Files           13       13              
  Lines         1233     1464     +231     
===========================================
+ Hits           993     1162     +169     
- Misses         240      302      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MicaiahReid MicaiahReid changed the title feat: upgrade clarinet to v2.2.1; enable use_nakamoto field to configure stacks chain for nakamoto feat: upgrade clarinet to v2.4.0; enable use_nakamoto field to configure stacks chain for nakamoto Mar 25, 2024
@MicaiahReid MicaiahReid merged commit 521acd1 into develop Mar 25, 2024
7 of 10 checks passed
@MicaiahReid MicaiahReid deleted the use-nakamoto branch March 25, 2024 20:50
blockstack-devops pushed a commit that referenced this pull request Mar 25, 2024
## [1.1.0](v1.0.0...v1.1.0) (2024-03-25)

### Features

* allow config path to be configured via env var ([#67](#67)) ([483fb8b](483fb8b))
* allow configuring k8s context with env var ([#71](#71)) ([f7e6bc3](f7e6bc3))
* check auth header before allowing access ([#47](#47)) ([6dcb36d](6dcb36d))
* remove pods; implement deployments/stateful sets ([#75](#75)) ([6399c19](6399c19))
* status page at `GET /` and `GET /api/v1/status` routes ([#68](#68)) ([d4c2290](d4c2290))
* upgrade clarinet to v2.4.0; enable `use_nakamoto` field to configure stacks chain for nakamoto ([#89](#89)) ([521acd1](521acd1))
* upgrade to using clarinet crate to parse config  ([#46](#46)) ([d57d3a1](d57d3a1))

### Bug Fixes

* add ACCESS_CONTROL_ALLOW_HEADERS to response header ([#52](#52)) ([225d2c9](225d2c9))
* add subPath for postgres volume mount ([#73](#73)) ([7812741](7812741))
* api container spelling fix ([7b52f93](7b52f93))
* don't require auth on OPTIONS requests; configure user-id prefix to make namespace ([#51](#51)) ([9fe7972](9fe7972))
* reduce permissions for cluster role ([#54](#54)) ([2ea50ea](2ea50ea))
* removing untemplated labels ([#82](#82)) ([e92dcb5](e92dcb5))
* set img pull policy for stacks blockchain api ([0b959c2](0b959c2))
* template ([#85](#85)) ([4399177](4399177))
@blockstack-devops
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

update devnet api to work for nakamoto neon + argon
3 participants