Skip to content

Commit

Permalink
fix(global): fix npmignore files and tsconfig.json
Browse files Browse the repository at this point in the history
it seems like lerna doesn't use the root npmignore file, plus tsconfig was extending a non existing
common file because only the sub dir is published
  • Loading branch information
shairez committed Aug 25, 2020
1 parent 85fa557 commit b29a1ee
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 32 deletions.
3 changes: 3 additions & 0 deletions packages/jasmine-given/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
node_modules
coverage
.nyc_output
25 changes: 19 additions & 6 deletions packages/jasmine-given/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
{
"extends": "../../tsconfig.common.json",
"compilerOptions": {
"module": "commonjs",
"target": "es5",
"moduleResolution": "node",
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"declaration": true, // generate .d.ts files
"declarationMap": true,
"noImplicitAny": true,
"noImplicitThis": false,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"sourceMap": true,
"downlevelIteration": true,
"lib": ["es2015", "es2016", "dom"],
"pretty": true,
"strict": true,
"baseUrl": ".",
"outDir": "dist",
"types": ["jasmine","node"],
"types": ["jasmine", "node"]
},
"include": [
"spec"
]
}
"include": ["spec"]
}
File renamed without changes.
25 changes: 19 additions & 6 deletions packages/jest-given/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
{
"extends": "../../tsconfig.common.json",
"compilerOptions": {
"module": "commonjs",
"target": "es5",
"moduleResolution": "node",
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"declaration": true, // generate .d.ts files
"declarationMap": true,
"noImplicitAny": true,
"noImplicitThis": false,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"sourceMap": true,
"downlevelIteration": true,
"lib": ["es2015", "es2016", "dom"],
"pretty": true,
"strict": true,
"baseUrl": ".",
"outDir": "dist",
"types": ["jest","node"]
"types": ["jest", "node"]
},
"include": [
"spec"
]
}
"include": ["spec"]
}
3 changes: 3 additions & 0 deletions packages/karma-jasmine-given/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
node_modules
coverage
.nyc_output
20 changes: 0 additions & 20 deletions tsconfig.common.json

This file was deleted.

0 comments on commit b29a1ee

Please sign in to comment.