bugfix: __releaseMetadataCacheBlock referenced NULL when multiple cac…

…he blocks released.
heterodb · Jan 20, 2025 · 1882098 · 1882098
1 parent 9d778a8
commit 1882098
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/src/arrow_fdw.c b/src/arrow_fdw.c
@@ -337,7 +337,7 @@ arrowFieldGetPGTypeHint(const ArrowField *field)
 static void
 __releaseMetadataCacheBlock(arrowMetadataCacheBlock *mc_block_curr)
 {
-	if (mc_block_curr)
+	while (mc_block_curr)
 	{
 		arrowMetadataCacheBlock *mc_block_next = mc_block_curr->next;
 
@@ -346,14 +346,9 @@ __releaseMetadataCacheBlock(arrowMetadataCacheBlock *mc_block_curr)
 			   !mc_block_curr->chain.prev &&
 			   !mc_block_curr->lru_chain.prev  &&
 			   !mc_block_curr->lru_chain.next);
-
-		while (mc_block_curr != NULL)
-		{
-			dlist_push_head(&arrow_metadata_cache->free_blocks,
-							&mc_block_curr->chain);
-			mc_block_curr = mc_block_next;
-			mc_block_next = mc_block_curr->next;
-		}
+		dlist_push_head(&arrow_metadata_cache->free_blocks,
+						&mc_block_curr->chain);
+		mc_block_curr = mc_block_next;
 	}
 }