Skip to content

Commit

Permalink
Update CI to Ubuntu 24.04 runner images (#315)
Browse files Browse the repository at this point in the history
Now that Ubuntu 24.04 images are available on GitHub Actions, we can update from the Ubuntu 22.04 images.

The new image version includes a newer Shellcheck release, which
requires that we ignore a new warning:
https://www.shellcheck.net/wiki/SC2028

See also:
actions/runner-images#9848
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZRd13d2ce2d455470495cbd34cf

GUS-W-16238120.
  • Loading branch information
edmorley authored Jul 15, 2024
1 parent 2f750b2 commit 7e267e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ permissions:

jobs:
shellcheck:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Run shellcheck
run: find . -type f \( -name "*.sh" -o -path "*/bin/*" \) ! -name '*.jq' | xargs -t shellcheck
build-stack:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- shellcheck
env:
Expand Down
1 change: 1 addition & 0 deletions tools/bin/install-heroku-files
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ echo "127.0.0.1 localhost localhost.localdomain" > "$IMG_MNT/etc/hosts"
echo "heroku-runtime" > "$IMG_MNT/etc/hostname"

for f in etc/profile etc/bash.bashrc; do
# shellcheck disable=SC2028 # https://www.shellcheck.net/wiki/SC2028
echo "export PS1='\\[\\033[01;34m\\]\\w\\[\\033[00m\\] \\[\\033[01;32m\\]$ \\[\\033[00m\\]'" > "$IMG_MNT/$f"
done

Expand Down

0 comments on commit 7e267e2

Please sign in to comment.