feat: add slideHasLink method and corresponding tests for link valida…

…tion (#795)
helsingborg-stad · Jan 28, 2025 · eadf9e9 · eadf9e9
1 parent 83f43b7
commit eadf9e9
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 1 deletion.
diff --git a/source/php/Module/Slider/Slider.php b/source/php/Module/Slider/Slider.php
@@ -202,7 +202,8 @@ private function getImageContract(int $imageId, ?array $focus = null): ?ImageCom
      * @return array
      */
     private function getLinkData(array $slide) {
-        if (empty($slide['link_url'])) {
+
+        if(!$this->slideHasLink($slide)) {
             return $slide;
         }
 
@@ -228,6 +229,24 @@ private function getLinkData(array $slide) {
         return $slide;
     }
 
+    /**
+     * Check if slide has link
+     * 
+     * @param array $slide
+     * @return bool
+     */
+    public function slideHasLink(array $slide):bool {
+        if( $slide['link_type'] !== 'internal' && $slide['link_type'] !== 'external' ) {
+            return false;
+        }
+
+        if( empty($slide['link_url']) ) {
+            return false;
+        }
+
+        return true;
+    }
+
     /**
      * Check if link url is valid
      * 

diff --git a/source/php/Module/Slider/Slider.test.php b/source/php/Module/Slider/Slider.test.php
@@ -0,0 +1,42 @@
+<?php
+
+namespace Modularity\Module\Slider;
+
+use PHPUnit\Framework\TestCase;
+
+class SliderTest extends TestCase {
+
+    /**
+     * @testdox class can be instantiated
+     */
+    public function testClassCanBeInstantiated() {
+        $slider = new Slider();
+        $this->assertInstanceOf(Slider::class, $slider);
+    }
+
+    /**
+     * @testdox slideHasLink returns false if link_type is not internal or external
+     */
+    public function testSlideHasLinkReturnFalseIfLinkTypeIndicatesNoLink() {
+        $slider = new Slider();
+        $linkUrl = 'https://example.com';
+        $this->assertFalse($slider->slideHasLink([ 'link_type' => 'false', 'link_url' => $linkUrl ]));
+    }
+
+    /**
+     * @testdox slideHasLink returns false if link_url is empty
+     */
+    public function testSlideHasLinkReturnFalseIfLinkUrlIsEmpty() {
+        $slider = new Slider();
+        $this->assertFalse($slider->slideHasLink([ 'link_type' => 'internal', 'link_url' => '' ]));
+    }
+
+    /**
+     * @testdox slideHasLink returns true if link_type is internal and link_url is not empty
+     */
+    public function testSlideHasLinkReturnTrueIfLinkTypeIsInternalAndLinkUrlIsNotEmpty() {
+        $slider = new Slider();
+        $linkUrl = 'https://example.com';
+        $this->assertTrue($slider->slideHasLink([ 'link_type' => 'internal', 'link_url' => $linkUrl ]));
+    }
+}