Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify pyproject.toml and make mamba_ssm optional. #138

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

giogix2
Copy link
Contributor

@giogix2 giogix2 commented Dec 6, 2024

What has changed?

  • Made the libraries mamba-ssm and causal-conv1d optional. Now they can be installed by specifying [mamba-ssm] within square brackets
  • Updated README.me to reflect the changes.
  • Removed setup.py.

What was causing the issue?

Originally the library mamba-ssm was using setup.py to install the package. However, this library expected torch to be already installed (see here), which setup.py was importing at the top of the file. This is why a fresh installation of mamba-ssm would fail.

How was it resolved.

The installation process was improved by introducing pyproject.toml as part of this PR, which was mentioned in this GitHub issue.

NOTE

Currently the new version (v2.2.3) of mamba-ssm is not available in Pypi yet (link). As of today (2024/12/06) the CI/CD to release the new package is running (though unsuccessfully). Until is available, this solution installs the packages from github, specifying the tag v2.2.3 to fix the version.

@bputzeys
Copy link
Collaborator

bputzeys commented Dec 6, 2024

I think we should test this in a fresh environment. I suggest to do this on the release.yml.

@giogix2
Copy link
Contributor Author

giogix2 commented Dec 6, 2024

FYI for reviewers. I'm going to add new non self-hosted runners on another branch/PR. I'll update this one when that's done.

@bputzeys bputzeys merged commit 08fb3a9 into main Dec 9, 2024
4 checks passed
@bputzeys bputzeys deleted the fix_mamba_ssm_install_dependency_issue branch December 9, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants