Modify pyproject.toml and make mamba_ssm optional. #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
What was causing the issue?
Originally the library mamba-ssm was using setup.py to install the package. However, this library expected torch to be already installed (see here), which setup.py was importing at the top of the file. This is why a fresh installation of mamba-ssm would fail.
How was it resolved.
The installation process was improved by introducing pyproject.toml as part of this PR, which was mentioned in this GitHub issue.
NOTE
Currently the new version (v2.2.3) of mamba-ssm is not available in Pypi yet (link). As of today (2024/12/06) the CI/CD to release the new package is running (though unsuccessfully). Until is available, this solution installs the packages from github, specifying the tag v2.2.3 to fix the version.