Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop depending on runit, do not insist on installing nginx from source #7

Closed
wants to merge 1 commit into from

Conversation

cosmin
Copy link

@cosmin cosmin commented Jun 19, 2012

No description provided.

@patcon
Copy link
Contributor

patcon commented Jul 11, 2012

nginx

I think the best thing to do might be to submit a pull request to opscode that creates a node['nginx']['install_method'] attribute that can be either package or source, and includes the associated recipes from default.

The PHP cookbook does this, and it makes situations like this much simpler, when we need to require a cookbook in a depending recipe.
https://github.com/opscode-cookbooks/php/blob/master/recipes/default.rb#L22

@cosmin
Copy link
Author

cosmin commented Jul 11, 2012

@cosmin
Copy link
Author

cosmin commented Jul 11, 2012

And the default nginx recipe already uses it to include the correct thing

https://github.com/opscode-cookbooks/nginx/blob/master/recipes/default.rb#L23

chef-jenkins needs to just get out of the way

@patcon
Copy link
Contributor

patcon commented Jul 11, 2012

dealio. my bad. Just gonna split these out so they can be judged independently. I'm bored and want to see some progress on these pull requests, so just doing housecleaning where I can :)

Would it be too much trouble to revise this one to be just related to nginx? I'll just put the other dead simple change in that linked issue

@fujin fujin closed this Feb 28, 2013
@patcon
Copy link
Contributor

patcon commented Mar 1, 2013

See #23 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants