Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Markus Wieczorek <[email protected]>
  • Loading branch information
msdoege and maggusw authored May 19, 2021
1 parent 4400c6b commit ea0f77f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Healex.HL7v2Anonymizer.Tests/AnonymizerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void AnonymizerTestAdtSegmentOrderWithAnonymization()

// Assert
Assert.IsTrue(originalMessage.SegmentCount == message.SegmentCount);
for (int i = 0; i < originalMessage.SegmentCount; i++)
for (var i = 0; i < originalMessage.SegmentCount; i++)
{
var originalSegment = originalMessage.Segments().ElementAt(i);
var messageSegment = message.Segments().ElementAt(i);
Expand Down
6 changes: 3 additions & 3 deletions Healex.HL7v2Anonymizer/Services/Anonymizer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ public bool Anonymize(Message message)
{
var isSuccess = true;

for (int segmentIndex = 0; segmentIndex < message.SegmentCount; segmentIndex++)
for (var segmentIndex = 0; segmentIndex < message.SegmentCount; segmentIndex++)
{
var segment = message.Segments().ElementAt(segmentIndex);
if (_replacementOptions.Segments.FirstOrDefault(segRep => segRep.Segment == segment.Name)
is var segmentReplacement && segmentReplacement != null)
is { } segmentReplacement)
{
// Create new temporary message for each repeating segment
// because we can't set values in all repeating segments at once
Expand All @@ -43,7 +43,7 @@ private Message AddSegmentAtIndex(Segment segment, int segmentIndex)
var tempMessage = new Message();

// workaround to ensure the segment gets it absolute (internal) SequenceNo re-assigned in AddNewSegment()
for (int i = 0; i < segmentIndex; i++)
for (var i = 0; i < segmentIndex; i++)
{
tempMessage.AddNewSegment(new Segment("DummySegment", new HL7Encoding()));
}
Expand Down

0 comments on commit ea0f77f

Please sign in to comment.