-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new typedef system_category to all steppers. #226
base: master
Are you sure you want to change the base?
Added new typedef system_category to all steppers. #226
Conversation
This new typedef must be one of - explicit_system_tag - second_order_system_tag - symplectic_system_tag - simple_symplectic_system_tag - symplectic_or_simple_symplectic_system_tag - implicit_system_tag and defines the type of the system the stepper handles. This can be usefull to automatically provide a proper system to a stepper using template spezialization.
* These tags can be used to detect which system category is used | ||
*/ | ||
|
||
struct explicit_system_tag {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to define the interface expected from the different system functor here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How? Just as (doxygen) comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just a short doxy showing how this interface is being called from inside the corresponding stepper.
struct second_order_system_tag {}; | ||
struct symplectic_system_tag {}; | ||
struct simple_symplectic_system_tag {}; | ||
struct symplectic_or_simple_symplectic_system_tag {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need 3 versions of symplectic tags? It seems only the last one is being used? If we keep all 3, shouldn't the last be derived from the two above to express the is_a relation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently all symplectic steppers support both "normal"- and simple-simplectic systems. So just having symplectic_or_simple_symplectic_system_tag is fine for now.
This new typedef must be one of
and defines the type of the system the stepper handles.
This can be usefull to automatically provide a proper system to a
stepper using template spezialization.