auto-hide menubar (can still be recalled by holding Alt key) #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
jonassvatos
changed the title
joaquimrocha
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks @jonassvatos . I think this behavior may not be what all users want, so we should add a menu to set it.
Also, please check out the git commit guidelines: https://headlamp.dev/docs/latest/contributing#2-follow-commit-guidelines
| @@ -1040,6 +1040,7 @@ function startElecron() { | |||
| contextIsolation: true, | |||
| preload: `${__dirname}/preload.js`, | |||
| }, | |||
| autoHideMenuBar: true, | |||
There was a problem hiding this comment.
This should be a setting. I imagine not all users want this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Electron menu bar is visible even when there is nothing custom, eg. settings or so on.
This PR effectively hides it, with the option to recall it again using Alt key.