-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: eslint-config: headlamp-plugin: eslint related updates #2549
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
d557baf
to
03f8492
Compare
Including eslint and related packages, and also typescript patch release. Fix the headlamp-plugin package.json template so it uses the correct format for creating packages. upgrade does not upgrade headlamp-k8s/eslint-config manually now. Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
03f8492
to
d4ee315
Compare
Because headlamp-k8s/eslint-config does not go to the top level of the node_modules anymore for some reason. Because prettier and eslint rely on it being there we need to keep it at the top level. Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
react-hooks eslint plugin is not used, does it make sense to keep/bump it? |
Yeah, I will remove it. I guess we should turn it on in a future version. Because I guess it will uncover issues in Headlamp and plugins... so just turning it on right now would not be a good idea. |
This release uncovered a bug in the upgrading of the headlamp-k8s/eslint-config package. It should upgrade to the version related to headlamp-plugin not to the "latest" version always. Because now the CI test job is broken in This was only in the alpha releases, so it probably only affects our headlamp repo CI (not plugins repo and not other peoples plugin repos). So I will fix that also in this PR too. |
Signed-off-by: René Dudfield <[email protected]>
ce3606f
to
40e2f09
Compare
Just saw the update, feel free to link #2560 to this PR in the case that the issue gets resolved |
There's a new headlamp-plugin out, as well as a new headlamp-k8s/eslint-config
To upgrade your plugin from within your plugin folder do:
npx @kinvolk/headlamp-plugin ugprade .