Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: eslint-config: headlamp-plugin: eslint related updates #2549

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

illume
Copy link
Collaborator

@illume illume commented Nov 7, 2024

There's a new headlamp-plugin out, as well as a new headlamp-k8s/eslint-config

To upgrade your plugin from within your plugin folder do:
npx @kinvolk/headlamp-plugin ugprade .

  • eslint-config: Bump typescript to 5.6.3
  • eslint-config: Bump yaml to 2.6.0
  • eslint-config: Bump @typescript-eslint/parser to 8.13.0
  • eslint-config: Bump eslint and related packages
  • eslint-config: Bump version to 0.7.0
  • frontend: headlamp-plugin: Bump headlamp-k8s/eslint-config and related
  • update plugin/examples to latest headlamp-plugin 0.10.0

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2024
@illume illume force-pushed the eslint-updates branch 2 times, most recently from d557baf to 03f8492 Compare November 7, 2024 21:41
Including eslint and related packages, and also typescript patch
release.

Fix the headlamp-plugin package.json template so it uses the
correct format for creating packages.

upgrade does not upgrade headlamp-k8s/eslint-config manually now.

Signed-off-by: René Dudfield <[email protected]>
Because headlamp-k8s/eslint-config does not go to the top
level of the node_modules anymore for some reason.
Because prettier and eslint rely on it being there we
need to keep it at the top level.

Signed-off-by: René Dudfield <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 7, 2024
@illume illume requested a review from a team November 7, 2024 23:07
@illume illume added the headlamp-plugin Related to the headlamp-plugin NPM package. label Nov 7, 2024
@sniok
Copy link
Contributor

sniok commented Nov 8, 2024

react-hooks eslint plugin is not used, does it make sense to keep/bump it?

@illume
Copy link
Collaborator Author

illume commented Nov 8, 2024

react-hooks eslint plugin is not used, does it make sense to keep/bump it?

Yeah, I will remove it. I guess we should turn it on in a future version. Because I guess it will uncover issues in Headlamp and plugins... so just turning it on right now would not be a good idea.

@illume illume marked this pull request as draft November 8, 2024 12:41
@illume
Copy link
Collaborator Author

illume commented Nov 8, 2024

This release uncovered a bug in the upgrading of the headlamp-k8s/eslint-config package. It should upgrade to the version related to headlamp-plugin not to the "latest" version always. Because now the CI test job is broken in main because it is trying to get the latest headlamp-k8s/eslint-config and that is not compatible with that older version of headlamp-plugin.

This was only in the alpha releases, so it probably only affects our headlamp repo CI (not plugins repo and not other peoples plugin repos).

So I will fix that also in this PR too.

Signed-off-by: René Dudfield <[email protected]>
@skoeva
Copy link
Contributor

skoeva commented Nov 12, 2024

Just saw the update, feel free to link #2560 to this PR in the case that the issue gets resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
headlamp-plugin Related to the headlamp-plugin NPM package. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants