Fix workload charts infinite spinning #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chart data was being accessed by using workload's names when they were set up using workload's class names, so this led to cases where the workload data was failed to be accessed because the name used in the classes didn't match the class name. Signed-off-by: Joaquim Rocha <[email protected]>
This should improve the view's performance especially when there are thousands of workloads. Signed-off-by: Joaquim Rocha <[email protected]>
illume
reviewed
Aug 5, 2024
illume
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where it could lead to infinite spinning in the workload overview charts.
It also makes it more performant by not joining the workload items on every render, which could be a problem when having thousands of items.
This was reported by @lijianzhi01 .
How to test: