-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winget: Updates manifest schema #2192
Conversation
0893498
to
99390bc
Compare
Something is very wrong here with the commit as there are 159 files changed. Seems like a rebase/merge issue. |
may need to downgrade the the prettier to not have this format error |
@vyncent-t Please rebase? Also, please do the formatting changes in a separate commit (or PR). |
99390bc
to
c6e488e
Compare
I have fixed the format issues, but I don't think this is all there is to update the format to 1.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the comments from Joaquim about needed changes.
Just compared the changes for 1.6.0 schema for each of these to what is in 1.5.0 and it doesn't seem to have any more additional required fields to be added and the only difference I can see is that someone must have changed a locale field ReleaseNotes since it's not in the the previous winget schemas for locale (it's only in 0.24.1) nor does it generate automatically when the script runs, although I can't find the source of that change like we were able to find the source of the change for the displayVersion being removed which has been removed here. other than that there aren't any differences that I can spot between the optional and required fields already used here |
c6e488e
to
36f354b
Compare
36f354b
to
c7031b4
Compare
The problem was the mismatch between the signoff and the author of the commit. It's fixed now, but we did talk about having the format closer to what was in that 0.24.1 version I had to modify this week. |
I think I may have pushed the windows copy on mistake (the one I have to create for validation) pushing the linux side one now |
Signed-off-by: Vincent T <[email protected]>
c7031b4
to
be339c1
Compare
current changes should be the same as the ones that are from 0.24.1 |
Update Winget Schema to 1.6.0
Fixes #2191
Description
This PR updates the Winget schema used in Headlamp from version 1.5.0 to 1.6.0. Additionally, the
DisplayVersion
field, which has been removed by Winget contributors, is removed to align with the latest schema requirements and maintain compatibility.Changes
DisplayVersion
field as per Winget contributors' guidelines.Verification
DisplayVersion
field does not cause any issues and aligns with the latest Winget schema.