frontend: apiProxy: Pass in namespace to testAuth #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows testAuth to take in a namespace parameter if given and fall back to using the default namespace if not given. Added changes to the testAuth tests in apiProxy.test.ts to account for this. Fixes: #754 Signed-off-by: Evangelos Skopelitis <[email protected]>
This gives us updated test coverage of testAuth in apiProxy. Signed-off-by: Evangelos Skopelitis <[email protected]>
|
This PR doesn't fix the #754 issue. It allows that function to be used now with a namespace, but it's not including the allowed namespace in it. |
joaquimrocha
approved these changes
Jul 24, 2024
illume
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows
testAuthto take in a namespace parameter if given and fall back to using the default namespace if not given. Added changes to thetestAuthtests inapiProxy.test.tsto account for this.related: #754
Testing
cd frontend && npm test -- --coveragetestAuthtests inapiProxy.test.tsare successful