headlamp-plugin: Add package command #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimrocha
requested review from
illume and
yolossn
and removed request for
illume
joaquimrocha
added
enhancement
illume
requested changes
Jul 19, 2024
illume
reviewed
Jul 19, 2024
illume
reviewed
Jul 19, 2024
|
Not a blocker but It would be nice to have the command also print the checksum that can be used in the |
joaquimrocha
force-pushed
the
create-headlamp-plugin-pack
branch
from
19271ba to
a45197f
Compare
|
Updated the branch with the checksum printing, test, and error when the final tarball already exists. |
joaquimrocha
force-pushed
the
create-headlamp-plugin-pack
branch
from
a45197f to
fceec7a
Compare
This command creates a tarball in the format that headlamp-plugin expects to be in when we use the install command. Signed-off-by: Joaquim Rocha <[email protected]>
joaquimrocha
force-pushed
the
create-headlamp-plugin-pack
branch
from
fceec7a to
17ac1ec
Compare
|
I have updated it again:
|
joaquimrocha
changed the title
yolossn
reviewed
Jul 24, 2024
Signed-off-by: Joaquim Rocha <[email protected]>
|
@yolossn there was an error in extract as it didn't return the error code when no packages were extracted. I have updated that. |
vyncent-t
pushed a commit
that referenced
this pull request
Jul 24, 2024
headlamp-plugin: Add package command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command creates a tarball in the format that headlamp-plugin expects to be in when we use the install command.