Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend use action if possible #2054

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

frontend use action if possible #2054

wants to merge 1 commit into from

Conversation

farodin91
Copy link
Contributor

No description provided.

joaquimrocha
joaquimrocha requested changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good but left a comment about a possible regression.
Also, the commit title should have frontend: as a prefix.
Something like this would be more descriptive:

frontend: Replace use of Tooltip+IconButton by Action

frontend/src/components/App/Notifications/index.tsx Outdated
aria-label={t('translation|Mark as read')}
size="medium"
>
<Icon icon="mdi:circle" color={theme.palette.error.main} height={12} width={12} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the color has not been taken into account in the replacement, right?
We do have notifications not visible for a couple of versions till we fix performance issues, but it would be good to have them look the same.

@illume illume marked this pull request as draft June 19, 2024 11:26
@farodin91 farodin91 force-pushed the frontend-use-action-if-possible branch from be965c3 to 7d83542 Compare January 3, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farodin91 @joaquimrocha