backend: Prevent OIDC errors when not in use

[skoeva]

This change prevents the spam of OIDC config errors in the logs when running the latest version of Headlamp without OIDC. Instead of logging an error when we check for the OIDC config, we simply return since we know we are not using OIDC auth.

Fixes: #1933

Testing

• Build a custom headlamp image in minikube and point the kubernetes-headlamp.yaml to it
• Apply the YAML (kubectl apply -f kubernetes-headlamp.yaml) and configure non-OIDC credentials
• Run headlamp in-cluster and watch the logs for the new headlamp pod: kubectl logs -n kube-system <pod-name> -f
• Open the app, click around, and ensure that the OIDC config errors do not appear

[illume]

I think rather than disabling logging of the error... instead OIDCTokenRefreshMiddleware should not be used if oidc is not configured. If the config.oidcClientID is not set, don't add the OIDCTokenRefreshMiddleware.

What do you think?

[skoeva]

I think rather than disabling logging of the error... instead OIDCTokenRefreshMiddleware should not be used if oidc is not configured. If the config.oidcClientID is not set, don't add the OIDCTokenRefreshMiddleware.

What do you think?

@illume the same check is performed on line 499, I think removing logging after 818 makes sense since it is assumed that OIDC auth is not being used by the comment on line 817. I'm not very familiar, but is there a reason to call OIDCTokenRefreshMiddleware when OIDC is not configured? line 818 assumes no config so that may need to be changed

[illume]

I'm not very familiar, but is there a reason to call OIDCTokenRefreshMiddleware when OIDC is not configured?

I don't think there's a reason to use OIDCTokenRefreshMiddleware when oidc is not configured. /cc @yolossn

[yolossn]

I don't think there's a reason to use OIDCTokenRefreshMiddleware when oidc is not configured. /cc @yolossn

Since the middleware is for the cluster proxy endpoint we cannot conditionally add it, this is because there can be certain clusters with OIDC and other without and all of them connect to the cluster via the cluster proxy endpoint.

[illume]

Thanks @yolossn

[illume]

🎉🎈

thanks