-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookbook to expose Prometheus counters. #1730
base: master
Are you sure you want to change the base?
Add cookbook to expose Prometheus counters. #1730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i blame myself
@tchoutri any comment? |
Sorry for the time, I got sidetracked by servant-quickcheck, which needed some love. Any reason why you didn't use https://hackage.haskell.org/package/wai-middleware-prometheus for the WAI integration? I'm asking since it's part of the same family of packages as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, quite a big review, I can understand if you'd rather let me handle it. :)
Two things.
I haven't discussed (a), which is more of a taste/personal-experience judgment but we could add a mention as well (and maybe link to another cookbook to embed a middleware/serve a Raw Application). |
@lucasdicioccio cool, thanks for the explanation. :) |
@lucasdicioccio Hi! Could you please rebase your PR on current |
@tchoutri do you mind if I squash the diffs? |
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
Co-authored-by: Théophile Choutri <[email protected]>
6c17dea
to
9118dc3
Compare
Co-authored-by: Théophile Choutri de Tarlé <[email protected]>
done; I've yet to retry the whole example, sorry for the delays |
@lucasdicioccio thanks! I and others will take a look. :) |
@tchoutri 😗
Not sure when I'll have time to address comments, so feel free to directly edit the PR.
The code itself is inspired from what I do in prodapi.