-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pick up PR for named routes cookbook again #1726
base: master
Are you sure you want to change the base?
pick up PR for named routes cookbook again #1726
Conversation
Thank you very much @MangoIV for this work! Reading the PR content, I feel like we ought to merge the NamedRoutes and Generics cookbooks together, under the NamedRoutes name. |
that's a good idea, I will do that then :) |
@MangoIV Are you still planning to do this? |
I am. I think we’re blocked by servant-qc (release, I have updated it) but I don’t know, let me check; will get to it this week perhaps ;) |
@MangoIV You may rebase your PR on top of |
Lovely thank you <3 |
a97a630
to
bc22eaf
Compare
Any news/blockers here regarding the merge? I also find this very valuable. |
@tfc yes, Mango still has to merge the two cookbooks. :) |
2ac385d
to
2a52a01
Compare
I have basically dropped the entire generic cookbook in favour of named routes, afaict I have transported all the information that didn't already occur in named routes but I would appreciate a thorough review to confirm. |
f2e3089
to
812dcf4
Compare
@ysangkok i still have a couple of failures sorry, I should mark it as draft again |
What's left to do here? The build errors have disappeared |
812dcf4
to
ff7b37a
Compare
- GHC <=9.2 does not have `Generically` for deriving via
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, I will merge in about one week once everyone has had the chance to review
This PR is supposed to pick up the great work started in #1542 and rebase on current changes as well as apply fixes suggested by the reviewers, potentially also addressing new change requests.