Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different summaries and details when reporting errors about non-null write-only attribute values #36274

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Use different summaries and details when reporting errors about non-null write-only attribute values #36274

merged 5 commits into from
Jan 8, 2025
+95 −23

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Jan 7, 2025 •
edited
Loading

Responding to internal feedback about how the error messages don't indicate which RPC type is triggering the error

TODO:

  • Update affected unit tests
  • Changelog entry for Changie

Target Release

1.11.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench changed the title Use different summaries when reporting errors about non-null write-only attribute values Use different summaries and details when reporting errors about non-null write-only attribute values Jan 7, 2025
@SarahFrench SarahFrench marked this pull request as ready for review January 7, 2025 12:54
@SarahFrench SarahFrench requested a review from a team as a code owner January 7, 2025 12:54
@SarahFrench SarahFrench force-pushed the change-wo-attr-error-summaries branch from d105474 to 4948ecc Compare January 8, 2025 10:25
@SarahFrench SarahFrench merged commit d5efc81 into main Jan 8, 2025
11 checks passed
@SarahFrench SarahFrench deleted the change-wo-attr-error-summaries branch January 8, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsa0x dsa0x dsa0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarahFrench @dsa0x