backend/oss: Adds new arguement tablestore_instance_name used to VPC scenario #36253
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trujillo-adam
requested changes
Jan 8, 2025
| @@ -95,6 +95,9 @@ The following configuration options or environment variables are supported: | |||
|
|
|||
| * `tablestore_endpoint` / `ALICLOUD_TABLESTORE_ENDPOINT` - (Optional) A custom endpoint for the TableStore API. | |||
|
|
|||
| * `tablestore_instance_name` - (Optional, Available since v1.11.0) A instance name of TableStore belongs. Default to parsing from `tablestore_endpoint`. | |||
There was a problem hiding this comment.
Suggested change
| * `tablestore_instance_name` - (Optional, Available since v1.11.0) A instance name of TableStore belongs. Default to parsing from `tablestore_endpoint`. | |
| * `tablestore_instance_name` - (Optional) Specifies the name of an instance that `TableStore` belongs to. By default, Terraform parses the name from `tablestore_endpoint`. |
The docs are versioned, so we don't need to include the min version directly in the prose.
| @@ -95,6 +95,9 @@ The following configuration options or environment variables are supported: | |||
|
|
|||
| * `tablestore_endpoint` / `ALICLOUD_TABLESTORE_ENDPOINT` - (Optional) A custom endpoint for the TableStore API. | |||
|
|
|||
| * `tablestore_instance_name` - (Optional, Available since v1.11.0) A instance name of TableStore belongs. Default to parsing from `tablestore_endpoint`. | |||
| It should be set Access URL explicitly when tablestore endpoint is a VPC access url | |||
There was a problem hiding this comment.
Suggested change
| It should be set Access URL explicitly when tablestore endpoint is a VPC access url | |
| You should set the access URL explicitly when the `tablestore` endpoint is a VPC access URL. |
Is this what you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform State OSS Backend uses Alibaba Cloud Tablestore to store state lock. There needs setting an instance name when putting lock data. Before, the instance name defaults to parsing from argument
tablestore_endpoint, but it will not work when it is a VPC endpoint. This PR provides a new argument tablestore_instance_name explicitly the instance name to meetVPC access scenario.
Target Release
1.11.x
Draft CHANGELOG entry
ENHANCEMENTS
backend/oss: Adds new arguement tablestore_instance_name used to VPC scenario