Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support defining period in custom metrics for target tracking policies #41385

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support defining period in custom metrics for target tracking policies #41385

wants to merge 3 commits into from

Conversation

carlosgaldino
Copy link
Contributor

Description

Following up from #41066, this patch adds the period field to the customized_metric_specification to allow overriding the period the metric is observed.

Relations

Relates #41066

References

Output from Acceptance Testing

% make testacc TESTS=TestAccAutoScalingPolicy PKG=autoscaling
...

My accounts don't support launch configuration so I can't test. It's the same reason as in the previous PR I opened before.

@carlosgaldino
Support defining period in custom metrics for target tracking policies
eedd2d8 
Following up from hashicorp#41066, this patch adds the `period` field to the
`customized_metric_specification` to allow overriding the period the
metric is observed.
@carlosgaldino carlosgaldino requested a review from a team as a code owner February 13, 2025 12:17
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/autoscaling Issues and PRs that pertain to the autoscaling service. needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosgaldino @justinretzolk