Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: Convert SingleNestedBlocks to ListNestedBlocks for aws_rekognition_stream_processor #41380

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 13, 2025

Description

This PR is to converted all SingleNestedBlocks to ListNestedBlocks in the aws_rekognition_stream_processor resource.

Relations

Relates #35813

References

n/a

Output from Acceptance Testing

$ make testacc TESTS=TestAccRekognitionStreamProcessor_ PKG=rekognition
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionStreamProcessor_'  -timeout 360m -vet=off
2025/02/12 23:26:02 Initializing Terraform AWS Provider...
=== RUN   TestAccRekognitionStreamProcessor_basic
=== PAUSE TestAccRekognitionStreamProcessor_basic
=== RUN   TestAccRekognitionStreamProcessor_disappears
=== PAUSE TestAccRekognitionStreamProcessor_disappears
=== RUN   TestAccRekognitionStreamProcessor_connectedHome
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome
=== RUN   TestAccRekognitionStreamProcessor_faceRecognition
=== PAUSE TestAccRekognitionStreamProcessor_faceRecognition
=== RUN   TestAccRekognitionStreamProcessor_faceRecognition_boundingBox
=== PAUSE TestAccRekognitionStreamProcessor_faceRecognition_boundingBox
=== RUN   TestAccRekognitionStreamProcessor_faceRecognition_polygon
=== PAUSE TestAccRekognitionStreamProcessor_faceRecognition_polygon
=== RUN   TestAccRekognitionStreamProcessor_tags
=== PAUSE TestAccRekognitionStreamProcessor_tags
=== CONT  TestAccRekognitionStreamProcessor_basic
=== CONT  TestAccRekognitionStreamProcessor_tags
=== CONT  TestAccRekognitionStreamProcessor_faceRecognition_boundingBox
=== CONT  TestAccRekognitionStreamProcessor_connectedHome
=== CONT  TestAccRekognitionStreamProcessor_disappears
=== CONT  TestAccRekognitionStreamProcessor_faceRecognition
=== CONT  TestAccRekognitionStreamProcessor_faceRecognition_polygon
--- PASS: TestAccRekognitionStreamProcessor_disappears (99.94s)
--- PASS: TestAccRekognitionStreamProcessor_basic (103.47s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition_boundingBox (111.89s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition_polygon (111.91s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome (114.27s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition (115.20s)
--- PASS: TestAccRekognitionStreamProcessor_tags (130.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        130.876s

$

@acwwat acwwat requested a review from a team as a code owner February 13, 2025 04:32
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rekognition Issues and PRs that pertain to the rekognition service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Feb 13, 2025
@acwwat acwwat force-pushed the b-aws_rekognition_stream_processor-convert_single_nested_blocks_to_list_nested_blocks branch from bbe895d to 327e862 Compare February 13, 2025 04:35
@acwwat acwwat force-pushed the b-aws_rekognition_stream_processor-convert_single_nested_blocks_to_list_nested_blocks branch from 327e862 to ed553bb Compare February 13, 2025 04:56
@acwwat acwwat changed the title Convert SingleNestedBlocks to ListNestedBlocks for aws_rekognition_stream_processor fix: Convert SingleNestedBlocks to ListNestedBlocks for aws_rekognition_stream_processor Feb 13, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2025
Attributes: map[string]schema.Attribute{
"x": schema.Float64Attribute{
Description: "The value of the X coordinate for a point on a Polygon.",
Optional: true,
Required: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attributes: map[string]schema.Attribute{
"height": schema.Float64Attribute{
Description: "Height of the bounding box as a ratio of the overall image height.",
Required: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the polygon arguments, should these be optional?
https://docs.aws.amazon.com/rekognition/latest/APIReference/API_BoundingBox.html

@jar-b jar-b added this to the v6.0.0 milestone Feb 14, 2025
@acwwat acwwat marked this pull request as draft February 14, 2025 19:49
@acwwat acwwat changed the title fix: Convert SingleNestedBlocks to ListNestedBlocks for aws_rekognition_stream_processor [WIP] fix: Convert SingleNestedBlocks to ListNestedBlocks for aws_rekognition_stream_processor Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. service/rekognition Issues and PRs that pertain to the rekognition service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants